Inline serde_core into serde in docsrs mode#2991
Conversation
e92fb39 to
f8137c7
Compare
|
oof. Very hacky. I'd prefer to just keep the status quo. It's not that bad and we can use it to prioritize the rustdoc issues more |
|
I would be grateful if you could expedite some fixes in rustdoc, but in my opinion having a workaround in place until rustdoc gets fixed is less bad than having the documentation remain in the current state for the same duration. The workaround can be removed as soon as the version of nightly rustdoc used by docs.rs no longer produces less legible / less copy-pasteable documentation without it. Beyond the associated type issue from the screenshots which is my prevailing concern, here are some other issues you could help with, which I have noticed in the serde documentation with re-exports:
Some other things that are solved by the workaround in this PR, which are not going to be solved in rustdoc and we will need some other workaround (probably easy) if not using this one:
|
#2608 regressed the rustdoc rendered documentation of
serdein many ways because rustdoc does not currently handle documentation of cross-crate re-exported items well. For example there is not enough information in the rmeta of dependencies to accurately reconstruct the way that trait associated types are named in signatures. The A-cross-crate-reexports label in rust-lang/rust records numerous other issues.Before #2608:
After #2608:
This PR works around the cross-crate re-export issues by inlining the items defined by
serde_coreintoserdewhen building documentation for docs.rs.